Add support for persisting dates with microsecond precision #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMage
added a commit
to MrMage/fluent-postgresql
that referenced
this pull request
Mar 13, 2018
MrMage
added a commit
to Timing-GmbH/fluent
that referenced
this pull request
Mar 13, 2018
MrMage
added a commit
to Timing-GmbH/fluent
that referenced
this pull request
Mar 13, 2018
tanner0101
reviewed
Mar 13, 2018
| @@ -37,7 +37,8 @@ extension Date: PostgreSQLDataCustomConvertible { | |||
|
|
|||
| /// See `PostgreSQLDataCustomConvertible.convertToPostgreSQLData()` | |||
| public func convertToPostgreSQLData() throws -> PostgreSQLData { | |||
| return PostgreSQLData(type: .timestamp, format: .text, data: Data(description.utf8)) | |||
| return PostgreSQLData(type: .timestamp, format: .binary, | |||
| data: Int64(self.timeIntervalSince(_psqlDateStart) * Double(_microsecondsPerSecond)).data) | |||
There was a problem hiding this comment.
please format with only 1 tab indentation, or all on one line (no "xcode formatting")
Note that I have not made parsing the textual format of the timestamp type more accurate - do we need that? If so, where is that format documented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I have not made parsing the textual format of the timestamp type more accurate - do we need that? If so, where is that format documented?